Skip to content

Rollout use vLLM V1 engine #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 8 commits into from
May 8, 2025
Merged

Rollout use vLLM V1 engine #31

pan-x-c merged 8 commits into from
May 8, 2025

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented May 7, 2025 •
edited
Loading

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 7, 2025

/run-unittest

@pan-x-c pan-x-c added the enhancement New feature or request label May 7, 2025
@github-actions
Copy link

github-actions bot commented May 7, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
19 16 3 0 0 0 0 712ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer The test failed in the call phase
❌ tests/common/config_test.py::TestConfig::test_all_examples_are_valid The test failed in the call phase due to an exception
❌ tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool The test failed in the call phase

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ❌ 1ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ❌ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSync::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsync::test_generate ✅ 40ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 208ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 186ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ❌ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 227ms

Github Test Reporter by CTRF 💚

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 7, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented May 7, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
19 16 3 0 0 0 0 698ms

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer The test failed in the call phase
❌ tests/common/config_test.py::TestConfig::test_all_examples_are_valid The test failed in the call phase due to an exception
❌ tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool The test failed in the call phase

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ❌ 1ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ❌ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSync::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsync::test_generate ✅ 40ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 201ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 172ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ❌ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 235ms

Github Test Reporter by CTRF 💚

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 8, 2025

/run-unittest

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented May 8, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented May 8, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
22 22 0 0 0 0 0 844ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 4ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 1ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 37ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 55ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 55ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 175ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 190ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 19ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 219ms

Github Test Reporter by CTRF 💚

@pan-x-c pan-x-c merged commit 6c56401 into modelscope:main May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyushuo chenyushuo chenyushuo approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pan-x-c @chenyushuo